Github user eatoncys commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r132388819
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -370,6 +370,14 @@ case class WholeStageCodegenExec(child: SparkPlan) 
extends UnaryExecNode with Co
     
       override def doExecute(): RDD[InternalRow] = {
         val (ctx, cleanedSource) = doCodeGen()
    +    if (ctx.isTooLongGeneratedFunction) {
    +      logWarning("Found too long generated codes and JIT optimization 
might not work, " +
    +        "Whole-stage codegen disabled for this plan, " +
    +        "You can change the config spark.sql.codegen.MaxFunctionLength " +
    +        "to adjust the function length limit:\n "
    +        + s"$treeString")
    +      return child.execute()
    +    }
    --- End diff --
    
    Ok ,I have added a test, would you like to review it again, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to