Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18910#discussion_r132581612
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala
 ---
    @@ -162,7 +163,11 @@ private[mesos] object MesosSchedulerBackendUtil 
extends Logging {
         }
     
         conf.getOption("spark.mesos.network.name").map { name =>
    -      val info = NetworkInfo.newBuilder().setName(name).build()
    +      val networkLabels = 
MesosProtoUtils.mesosLabels(conf.get(NETWORK_LABELS).getOrElse(""))
    --- End diff --
    
    Shouldn't spark.mesos.network.name have a config name like labels have: 
NETWORK_LABELS?
    At some point all config options should be placed in one file to be easily 
manipulated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to