Github user susanxhuynh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18910#discussion_r132766509
  
    --- Diff: 
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala
 ---
    @@ -582,6 +583,10 @@ class MesosCoarseGrainedSchedulerBackendSuite extends 
SparkFunSuite
         val networkInfos = launchedTasks.head.getContainer.getNetworkInfosList
         assert(networkInfos.size == 1)
         assert(networkInfos.get(0).getName == "test-network-name")
    +    assert(networkInfos.get(0).getLabels.getLabels(0).getKey == "key1")
    +    assert(networkInfos.get(0).getLabels.getLabels(0).getValue == "val1")
    +    assert(networkInfos.get(0).getLabels.getLabels(1).getKey == "key2")
    +    assert(networkInfos.get(0).getLabels.getLabels(1).getValue == "val2")
    --- End diff --
    
    @ArtRand I believe this _is_ testing the worker tasks: (L.572) the 
`setBackend()` method creates a MesosCoarseGrainedSchedulerBackend, L.577-579 
creates the requirements for an Executor, (L. 580) backend.resourceOffers() 
looks for an offer that matches the requirements and launches an Executor task. 
    There is a separate unit test above, in MesosClusterSchedulerSuite.scala, 
which checks for the labels in the driver itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to