Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18810#discussion_r132611417
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
 ---
    @@ -149,4 +150,56 @@ class WholeStageCodegenSuite extends SparkPlanTest 
with SharedSQLContext {
           assert(df.collect() === Array(Row(1), Row(2)))
         }
       }
    +
    +  def genGroupByCodeGenContext(caseNum: Int, maxLinesPerFunction: Int): 
CodegenContext = {
    +    val caseExp = (1 to caseNum).map { i =>
    +      s"case when id > $i and id <= ${i + 1} then 1 else 0 end as v$i"
    +    }.toList
    +
    +    spark.conf.set("spark.sql.codegen.maxLinesPerFunction", 
maxLinesPerFunction)
    --- End diff --
    
    withSQLConf?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to