Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18810#discussion_r132731370
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -572,6 +572,14 @@ object SQLConf {
"disable logging or -1 to apply no limit.")
.createWithDefault(1000)
+ val WHOLESTAGE_MAX_LINES_PER_FUNCTION =
buildConf("spark.sql.codegen.maxLinesPerFunction")
+ .internal()
+ .doc("The maximum lines of a single Java function generated by
whole-stage codegen. " +
+ "When the generated function exceeds this threshold, " +
+ "the whole-stage codegen is deactivated for this subtree of the
current query plan.")
+ .intConf
+ .createWithDefault(1500)
--- End diff --
I think that this value depends on what code is generated by the
whole-stage codegen for each query. In other words, when Java byte code per
line is larger than 6 (= `8192 / 1500`) in a generated Java code, `1500` would
not work.
@eatoncys why are you sure that this can apply to other Java programs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
