Github user tsudukim commented on the pull request:

    https://github.com/apache/spark/pull/2612#issuecomment-57606210
  
    Generally, using LF as EOL character of *.cmd files may cause some troubles.
    For example, when the *.cmd file includes LF and multibyte character, some 
characters of head of line might be removed internally for some reason. The 
problem @sarutak mentioned seems to be same as this.
    In another case, "goto" may go to wrong place. This problem occured once in 
ruby-lang project. Their build script for Windows happened to be LF, and they 
faced "strange behaviour of cmd.exe".
    https://bugs.ruby-lang.org/issues/10145
    
    I know *.cmd with LF runs seemingly well in many cases, but sometimes cause 
inexplicable trouble because LF is defenetely not the proper EOL character of 
Windows *.cmd files.
    So if possible, I think we should use CRLF as EOL to avoid such trouble.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to