Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2623#discussion_r18330540
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1437,7 +1437,13 @@ private[spark] object Utils extends Logging {
val serviceString = if (serviceName.isEmpty) "" else s" '$serviceName'"
for (offset <- 0 to maxRetries) {
// Do not increment port if startPort is 0, which is treated as a
special port
- val tryPort = if (startPort == 0) startPort else (startPort +
offset) % 65536
+ val _tryPort = if (startPort == 0) startPort else (startPort +
offset) % 65536
--- End diff --
I think it is ok. By this PR even root user can not use port 1- 1024(leave
them to system) in spark. An important point here is we can not change the port
before, for example the old app web ui is 4040, we can not change it. But if
use ```... else ((startPort + offset - 1024) % (65536 - 1024)) + 1024``` , the
new web ui port will be 4040+1024
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
