Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18934#discussion_r132914869
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -423,7 +423,14 @@ case class InsertIntoHiveTable(
// Attempt to delete the staging directory and the inclusive files. If
failed, the files are
// expected to be dropped at the normal termination of VM since
deleteOnExit is used.
try {
- createdTempDir.foreach { path =>
path.getFileSystem(hadoopConf).delete(path, true) }
+ createdTempDir.foreach { path =>
+ path.getFileSystem(hadoopConf).delete(path, true)
+ // If we successfully delete the staging directory, remove it from
FileSystem's cache.
+ val fs = path.getFileSystem(hadoopConf)
--- End diff --
You call getFileSystem twice; you can reuse it.
I suppose this adds an additional check to see if the file exists, but this
won't be called that often.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
