Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18934#discussion_r132916627
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -156,69 +156,71 @@ class SQLQuerySuite extends QueryTest with
SQLTestUtils with TestHiveSingleton {
}
test("SPARK-6851: Self-joined converted parquet tables") {
- val orders = Seq(
- Order(1, "Atlas", "MTB", 234, "2015-01-07", "John D", "Pacifica",
"CA", 20151),
- Order(3, "Swift", "MTB", 285, "2015-01-17", "John S", "Redwood
City", "CA", 20151),
- Order(4, "Atlas", "Hybrid", 303, "2015-01-23", "Jones S", "San
Mateo", "CA", 20151),
- Order(7, "Next", "MTB", 356, "2015-01-04", "Jane D", "Daly City",
"CA", 20151),
- Order(10, "Next", "YFlikr", 187, "2015-01-09", "John D", "Fremont",
"CA", 20151),
- Order(11, "Swift", "YFlikr", 187, "2015-01-23", "John D", "Hayward",
"CA", 20151),
- Order(2, "Next", "Hybrid", 324, "2015-02-03", "Jane D", "Daly City",
"CA", 20152),
- Order(5, "Next", "Street", 187, "2015-02-08", "John D", "Fremont",
"CA", 20152),
- Order(6, "Atlas", "Street", 154, "2015-02-09", "John D", "Pacifica",
"CA", 20152),
- Order(8, "Swift", "Hybrid", 485, "2015-02-19", "John S", "Redwood
City", "CA", 20152),
- Order(9, "Atlas", "Split", 303, "2015-02-28", "Jones S", "San
Mateo", "CA", 20152))
-
- val orderUpdates = Seq(
- Order(1, "Atlas", "MTB", 434, "2015-01-07", "John D", "Pacifica",
"CA", 20151),
- Order(11, "Swift", "YFlikr", 137, "2015-01-23", "John D", "Hayward",
"CA", 20151))
-
- orders.toDF.createOrReplaceTempView("orders1")
- orderUpdates.toDF.createOrReplaceTempView("orderupdates1")
+ withTable("orders", "orderupdates") {
--- End diff --
The newly added test has been bitten by an existing test which doesn't drop
created table. Those old tests all the same. I can move them to another minor
PR if you think it's necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
