Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2561#discussion_r18358551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -226,6 +229,25 @@ object ConstantFolding extends Rule[LogicalPlan] {
}
/**
+ * Replaces [[In (value, seq[Literal])]] with optimized version[[InSet
(value, HashSet[Literal])]]
+ * which is much faster
+ */
+object OptimizedIn extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case q: LogicalPlan => q transformExpressionsDown {
+ case In(v, list) if list.exists {
+ case Literal(_ , _) => true
+ case UnaryMinus(_) => true
--- End diff --
Why special handling for UnaryMinus? If the underlying thing is a literal
this will get constant folded away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
