Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2561#issuecomment-57683854
Another thing is there should be some tests for this. Probably in
`ExpressionEvaluationSuite`. Also perhaps create a class similar to
`ConstantFoldingSuite`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]