Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r133316362
--- Diff: scalastyle-config.xml ---
@@ -86,7 +86,7 @@ This file is divided into 3 sections:
</check>
<check level="error"
class="org.scalastyle.scalariform.ObjectNamesChecker" enabled="true">
- <parameters><parameter
name="regex"><![CDATA[[A-Z][A-Za-z]*]]></parameter></parameters>
+ <parameters><parameter
name="regex"><![CDATA[(config|[A-Z][A-Za-z]*)]]></parameter></parameters>
--- End diff --
Agree it makes more sense to make the whole thing `private[spark]`, but
couldn't you just turn the rule off around this object, like we do for println?
(Also I'm confused why `package object config` doesn't violate the rule).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
