Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r133725104
--- Diff: scalastyle-config.xml ---
@@ -86,7 +86,7 @@ This file is divided into 3 sections:
</check>
<check level="error"
class="org.scalastyle.scalariform.ObjectNamesChecker" enabled="true">
- <parameters><parameter
name="regex"><![CDATA[[A-Z][A-Za-z]*]]></parameter></parameters>
+ <parameters><parameter
name="regex"><![CDATA[(config|[A-Z][A-Za-z]*)]]></parameter></parameters>
--- End diff --
ok makes sense. I wasn't paying enough attention to the actual change at
first, thought you were just turning the rule entirely off, but I agree this
changes makes sense.
btw I was curious why `package object config` was OK -- its just a
hard-coded special case:
https://github.com/scalastyle/scalastyle/blob/master/src/main/scala/org/scalastyle/scalariform/ClassNamesChecker.scala#L74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
