Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/18887
> I feel like we should have one version where the old code is still
available, controlled by a feature flag.
I'm not sure exactly what you're suggesting. The default behavior is still,
as much as possible, the old one: everything is kept in memory. Keeping the
exact old code in place would mean forking `FsHistoryProvider`, which is not
something I see as desirable.
Also, forgot to reply to an earlier comment by @jerryshao :
> looks like we removed some synchronizations here, I'm not sure if
KVStore instances are thread safe, so a lot of the old synchronization in
this class does not apply. There was code before that used non-thread-safe data
structures (such as `attemptsToClean`), which has been replaced with storing
things in the KVStore instance instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
