Github user squito commented on the issue:
https://github.com/apache/spark/pull/18887
>> I feel like we should have one version where the old code is still
available, controlled by a feature flag.
>I'm not sure exactly what you're suggesting. The default behavior is
still, as much as possible, the old one: everything is kept in memory. Keeping
the exact old code in place would mean forking FsHistoryProvider, which is not
something I see as desirable.
long-term, definitely not desirable. My concern is that there is a lot of
new code taking effect here, on some important functionality -- we don't want
some bug to prevent adoption of 2.3. For one version, you could leave the old
one available, rename it to something else, and put a big disclaimer in the
code that its obsolete, and as long as thing are smooth for 2.3 delete it
entirely for 2.4. The HS isn't as core or tricky as the network module but I'm
thinking of this like netty vs. nio.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
