Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18966#discussion_r135415687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -769,16 +769,27 @@ class CodegenContext {
foldFunctions: Seq[String] => String = _.mkString("", ";\n", ";")):
String = {
val blocks = new ArrayBuffer[String]()
val blockBuilder = new StringBuilder()
+ val defaultMaxLines = 100
+ val maxLines = if (SparkEnv.get != null) {
+
SparkEnv.get.conf.getInt("spark.sql.codegen.expressions.maxCodegenLinesPerFunction",
--- End diff --
This is not following what we are doing for the other SQLConf. I am also
thinking if we should just put it into `StaticSQLConf`. Let me check it with
others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
