Github user hhbyyh commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18610#discussion_r135418289
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -72,6 +72,22 @@ private[regression] trait LinearRegressionParams extends 
PredictorParams
     }
     
     /**
    + * Params for linear regression.
    + */
    +private[regression] trait LinearRegressionParams extends 
LinearRegressionModelParams
    --- End diff --
    
    It maybe cleaner if we just move the param `initialModel` into 
LinearRegression? so we don't have to touch the class hierarchy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to