Github user hhbyyh commented on a diff in the pull request:
https://github.com/apache/spark/pull/18610#discussion_r135418170
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -226,6 +246,12 @@ class LinearRegression @Since("1.3.0")
(@Since("1.3.0") override val uid: String
if (($(solver) == Auto &&
numFeatures <= WeightedLeastSquares.MAX_NUM_FEATURES) || $(solver)
== Normal) {
+
+ if (isSet(initialModel)) {
+ logWarning("Initial model will be ignored if fitting by normal
solver. " +
--- End diff --
Since initial model is a pretty important parameter. By setting the initial
model, user would expect it to work and they may neglect the warning in the
overwhelming Spark logs.
Maybe we can move the parameter check to `transformSchema` and throws an
exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
