Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17014#discussion_r135695930
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -85,6 +86,10 @@ abstract class Predictor[
M <: PredictionModel[FeaturesType, M]]
extends Estimator[M] with PredictorParams {
+ protected[spark] var storageLevel = StorageLevel.NONE
+
+ protected def handlePersistence = storageLevel == StorageLevel.NONE
--- End diff --
Yes... so it looks like a change breaking thread safety.
and `handlePersistence` is information related to `Dataset`, but it is add
as a member of `Predictor`, I think the design is a little weird and maybe will
cause other potential bugs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
