Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/17014#discussion_r135740464
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -85,6 +86,10 @@ abstract class Predictor[
M <: PredictionModel[FeaturesType, M]]
extends Estimator[M] with PredictorParams {
+ protected[spark] var storageLevel = StorageLevel.NONE
+
+ protected def handlePersistence = storageLevel == StorageLevel.NONE
--- End diff --
+1 @WeichenXu123 We can't store persistence level as the member variable of
_Predictor_, since we may use one estimator to fit on the same dataset multiple
times, and it may lead duplicated persistence if we don't handle it carefully.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
