Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19068#discussion_r135855867
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
    @@ -81,11 +81,7 @@ private[hive] object SparkSQLCLIDriver extends Logging {
           System.exit(1)
         }
     
    -    val cliConf = new HiveConf(classOf[SessionState])
    -    // Override the location of the metastore since this is only used for 
local execution.
    -    HiveUtils.newTemporaryConfiguration(useInMemoryDerby = false).foreach {
    --- End diff --
    
    I don't think you have answered the question here - for example, the 
original code will update the `HiveConf.ConfVars.METASTORECONNECTURLKEY` 
property here, but you don't touch that after the change. I'm not confident to 
make that behavior change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to