Github user yaooqinn commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19068#discussion_r135940059
  
    --- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
    @@ -81,11 +81,7 @@ private[hive] object SparkSQLCLIDriver extends Logging {
           System.exit(1)
         }
     
    -    val cliConf = new HiveConf(classOf[SessionState])
    -    // Override the location of the metastore since this is only used for 
local execution.
    -    HiveUtils.newTemporaryConfiguration(useInMemoryDerby = false).foreach {
    --- End diff --
    
    METASTORECONNECTURLKEY connects derby by default, we may set this key in 
hive-site.xml to talk with metastore. hiveclient will use the state init here, 
I don't think we should beinit hive conf as the old way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to