Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18875#discussion_r136995614
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
---
@@ -27,21 +27,45 @@ import org.apache.spark.sql.catalyst.util.{ArrayData,
DateTimeUtils, MapData}
import org.apache.spark.sql.types._
private[sql] class JacksonGenerator(
- schema: StructType,
+ childType: DataType,
--- End diff --
This parameter looks weird to me. We don't want to tightly link
`JacksonGenerator` to what this PR did.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
