Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18875#discussion_r136997720
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala
 ---
    @@ -27,21 +27,45 @@ import org.apache.spark.sql.catalyst.util.{ArrayData, 
DateTimeUtils, MapData}
     import org.apache.spark.sql.types._
     
     private[sql] class JacksonGenerator(
    -    schema: StructType,
    +    childType: DataType,
    +    rowSchema: StructType,
    --- End diff --
    
    That's said, for now `JacksonGenerator` supports to write out a struct or 
an array of struct. After revising, it can also support to write out map, array 
of map.
    
    Once a `JacksonGenerator` is initialized with a `MapType`, it is not valid 
to call the API `write(row: InternalRow)`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to