Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19041#discussion_r138761658
--- Diff:
core/src/main/scala/org/apache/spark/storage/BlockManagerMessages.scala ---
@@ -32,8 +32,13 @@ private[spark] object BlockManagerMessages {
// blocks that the master knows about.
case class RemoveBlock(blockId: BlockId) extends ToBlockManagerSlave
+ // Replicate block excluding certain executors for graceful shutdown.
--- End diff --
Adding this comment makes the whole comment block a little bit confusing.
(As in, which one is correct?)
If you want to document the `excluding` parameter you can create a scaladoc
comment instead. Mentioning "graceful shutdown" here doesn't really add a lot
of information.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
