Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19239#discussion_r139029401
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -560,13 +567,24 @@ class StreamExecution(
}
if (hasNewData) {
var batchWatermarkMs = offsetSeqMetadata.batchWatermarkMs
- // Update the eventTime watermark if we find one in the plan.
+ // Update the eventTime watermarks if we find any in the plan.
--- End diff --
Well, we're updating multiple watermarks in the map. We later update
`offsetSeqMetadata` with the new minimum one, but that's not in this block.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
