Github user joseph-torres commented on a diff in the pull request: https://github.com/apache/spark/pull/19239#discussion_r139029187 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -130,6 +130,13 @@ class StreamExecution( protected var offsetSeqMetadata = OffsetSeqMetadata( batchWatermarkMs = 0, batchTimestampMs = 0, sparkSession.conf) + /** + * A map from watermarked attributes to their current watermark. The minimum watermark + * timestamp present here will be used as the overall query watermark in offsetSeqMetadata; + * the query watermark is what's logged and used to age out old state. + */ + protected var attributeWatermarkMsMap: AttributeMap[Long] = AttributeMap(Seq()) --- End diff -- This map has to persist and get updated across batches, and I'm not sure how to do that with a local variable or a val.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org