Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r140336092
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/array/ByteArrayMethods.java
---
@@ -46,6 +47,42 @@ public static int roundNumberOfBytesToNearestWord(int
numBytes) {
* @return true if the arrays are equal, false otherwise
*/
public static boolean arrayEquals(
+ MemoryBlock leftBase, long leftOffset, MemoryBlock rightBase, long
rightOffset, final long length) {
--- End diff --
Not sure if you missed this. I still see the code duplication. This entire
method block could be replaced as:
```
arrayEquals(
leftBase.getBaseObject(),
leftOffset,
rightBase.getBaseObject(),
rightOffset,
length
)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
