Github user tejasapatil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19222#discussion_r140336704
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/expressions/HiveHasher.java
 ---
    @@ -38,6 +39,10 @@ public static int hashLong(long input) {
         return (int) ((input >>> 32) ^ input);
       }
     
    +  public static int hashUnsafeBytesMB(MemoryBlock base, long offset, int 
lengthInBytes) {
    --- End diff --
    
    `BytesMB` seemed weird to read as `MB` is generally interpreted as mega 
bytes. How about `hashUnsafeBlock` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to