Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19222
Circling back to the inheritance discussion. My worry is that this will
introduce a lot polymorphic call sites in very performance critical code. Even
if you tag on final to each method, the call site will still be monomorphic.
There are two options from my end:
1. Convince me wrong, by posting benchmark before and after benchmark
results.
2. Use a single class that combines the various implementations. This is
very easy to do and will have relatively little overhead.
Also cc @rednaxelafx
In all I really think this work is worth the effort. It should make working
with Spark internals a lot easier/safer.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
