Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19222
Ok, I missed that you had moved these into the base class. I still look
forward to the benchmark :)...
I still think that the hierarchy does give any benefit. All block
subclasses implement `size`, `fill`, `setPageNum` & `getPageNum` in the same
way, and the other methods are either unused or can be generalized without a
problem. That leaves a few static constructors which can also be moved.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
