Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/19327#discussion_r140605854 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala --- @@ -324,17 +367,34 @@ case class StreamingSymmetricHashJoinExec( } } - /** Remove old buffered state rows using watermarks for state keys and values */ - def removeOldState(): Unit = { + /** + * Builds an iterator over old state key-value pairs, removing them lazily as they're produced. + * + * This iterator is dangerous! It must be consumed fully before any other operations are made --- End diff -- Maybe tone down the language is a little :) Rather than saying "dangerous", uses `@note`
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org