Github user joseph-torres commented on the issue: https://github.com/apache/spark/pull/19327 I believe I've addressed all comments. Some refactorings made some comments obsolete, though. I've also fixed 1 bug and 1 test issue causing the 2 unit test failures. There's still the outstanding question of whether allRemovalsTimeMs can/should include time spent outer joining, in addition to test review.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org