Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1222#discussion_r18535329
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -58,43 +61,79 @@ private[spark] class EventLoggingListener(
       private val shouldOverwrite = 
sparkConf.getBoolean("spark.eventLog.overwrite", false)
       private val testing = sparkConf.getBoolean("spark.eventLog.testing", 
false)
       private val outputBufferSize = 
sparkConf.getInt("spark.eventLog.buffer.kb", 100) * 1024
    -  val logDir = EventLoggingListener.getLogDirPath(logBaseDir, appId)
    -  val logDirName: String = logDir.split("/").last
    -  protected val logger = new FileLogger(logDir, sparkConf, hadoopConf, 
outputBufferSize,
    -    shouldCompress, shouldOverwrite, Some(LOG_FILE_PERMISSIONS))
    +  private val fileSystem = Utils.getHadoopFileSystem(new URI(logBaseDir), 
hadoopConf)
    +
    +  // Only defined if the file system scheme is not local
    +  private var hadoopDataStream: Option[FSDataOutputStream] = None
    +
    +  // The Hadoop APIs have changed over time, so we use reflection to 
figure out
    +  // the correct method to use to flush a hadoop data stream. See 
SPARK-1518
    +  // for details.
    +  private val hadoopFlushMethod = {
    --- End diff --
    
    This is how the code was before. I'm just moving it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to