Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1222#discussion_r18539187
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -214,29 +231,64 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
}
}
- private def createReplayBus(logDir: FileStatus): (ReplayListenerBus,
ApplicationEventListener) = {
- val path = logDir.getPath()
- val elogInfo = EventLoggingListener.parseLoggingInfo(path, fs)
- val replayBus = new ReplayListenerBus(elogInfo.logPaths, fs,
elogInfo.compressionCodec)
- val appListener = new ApplicationEventListener
- replayBus.addListener(appListener)
- (replayBus, appListener)
+ private def replay(logPath: FileStatus, bus: ReplayListenerBus):
ApplicationEventListener = {
--- End diff --
The change is sort of necessary because of the way I decoupled
EventLoggingListener and ReplayListenerBus. Now opening the log and replaying
the log are different things, since the log can come from different places and
may have to be pre-processed.
I agree returning the listener is a little weird (although I wasn't too
converned about it in a private API). I changed it slightly at the cost of some
redundant work, let's see if you prefer that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
