Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r141073210
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -496,7 +517,7 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
var provider: FsHistoryProvider = null
try {
- provider = new FsHistoryProvider(conf)
+ provider = newProvider(conf)
--- End diff --
It seems worse to have this `newProvider` method and create a lot of diff.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
