Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18887#discussion_r140828145
--- Diff:
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
---
@@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends SparkFunSuite with
BeforeAndAfter with Matc
}
private def createTestConf(): SparkConf = {
- new SparkConf().set("spark.history.fs.logDirectory",
testDir.getAbsolutePath())
+ new SparkConf()
+ .set("spark.history.fs.logDirectory", testDir.getAbsolutePath())
+ .set(LOCAL_STORE_DIR, Utils.createTempDir().getAbsolutePath())
--- End diff --
Disagree. The code in the SHS, other than instantiation, is exactly the
same regardless of the underlying store implementation. Meaning that if both
stores are tested equally, this code should also work equally there.
By testing the disk store only, we're testing all the code involved here
(which is the interaction with the store itself + serialization, which is not
tested by the in-memory store).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
