Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19367#discussion_r141356477
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -85,6 +85,7 @@ public long nullsNativeAddress() {
@Override
public void close() {
+ super.close();
Platform.freeMemory(nulls);
--- End diff --
This comment is not related to this fix directly. However, is it better to
check whether each field is not `0` before calling `Platform.freeMemory()`? For
example, `data` or `lengthData/offsetData may be `0`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
