Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/19367#discussion_r141366208
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -85,6 +85,7 @@ public long nullsNativeAddress() {
@Override
public void close() {
+ super.close();
Platform.freeMemory(nulls);
--- End diff --
Yeah, it is a bit weird. The doc in the JDK8's `Unsafe. freeMemory()`
states the following: `The address passed to this method may be null, in which
case no action is taken.` See:
http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/sun/misc/Unsafe.java
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
