Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2644#discussion_r18544573 --- Diff: core/src/main/scala/org/apache/spark/Aggregator.scala --- @@ -40,10 +40,9 @@ case class Aggregator[K, V, C] ( def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]]): Iterator[(K, C)] = combineValuesByKey(iter, null) - def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]], - context: TaskContext): Iterator[(K, C)] = { + def combineValuesByKey(iter: Iterator[_ <: Product2[K, V]], context: TaskContext): Iterator[(K, C)] = { --- End diff -- This is > 100 chars. The correct style here is ``` def combineValuesByKey( iter: Iterator[...], context: TaskContext): Iterator[...] = { ... } ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org