Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2644#discussion_r18544949
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -845,7 +845,7 @@ private[spark] object Utils extends Logging {
         stdoutThread.join()   // Wait for it to finish reading output
         if (exitCode != 0) {
           logError(s"Process $command exited with code $exitCode: $output")
    -      throw new SparkException(s"Process $command exited with code 
$exitCode")
    --- End diff --
    
    I think we should just keep this. We use string interpolation at many 
places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to