Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19389#discussion_r141949009
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -149,7 +149,7 @@ object TypeCoercion {
           })
       }
     
    -  private def findWiderCommonType(types: Seq[DataType]): Option[DataType] 
= {
    +  def findWiderCommonType(types: Seq[DataType]): Option[DataType] = {
    --- End diff --
    
    surprisingly, `TypeCoercion` is totally public, so this should probably be 
`private[sql]`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to