Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19389#discussion_r141947058
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetPartitionDiscoverySuite.scala
---
@@ -249,6 +249,11 @@ class ParquetPartitionDiscoverySuite extends QueryTest
with ParquetTest with Sha
true,
rootPaths,
timeZoneId)
+ assert(actualSpec.partitionColumns === spec.partitionColumns)
+ assert(actualSpec.partitions.length === spec.partitions.length)
+ actualSpec.partitions.zip(spec.partitions).foreach { case (actual,
expected) =>
+ assert(actual === expected)
+ }
--- End diff --
just for my own understanding -- these added asserts are just to improve
failure msgs, right? They would have all been covered by the
`assert(actualSpec === spec)` below anywyay, right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
