Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19250#discussion_r143244400
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -266,6 +267,10 @@ final class DataFrameWriter[T] private[sql](ds: 
Dataset[T]) {
        * @since 1.4.0
        */
       def insertInto(tableName: String): Unit = {
    +    extraOptions.get(TimestampTableTimeZone.TIMEZONE_PROPERTY).foreach { 
tz =>
    --- End diff --
    
    The 
[spec](https://docs.google.com/document/d/1XmyVjr3eOJiNFjVeSnmjIU60Hq-XiZB03pgi3r1razM/edit#heading=h.jnyh4t7bhnlx)
 requests errors when using invalid time zones. I guess this would still fail 
with a different error in that case, so I can remove this if you're really 
against adding it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to