Github user zivanfi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143462649
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -266,6 +267,10 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
* @since 1.4.0
*/
def insertInto(tableName: String): Unit = {
+ extraOptions.get(TimestampTableTimeZone.TIMEZONE_PROPERTY).foreach {
tz =>
--- End diff --
Although other table properties don't have similar checks, their effect is
usually easy to see. The effect of this specific table property however is not
immediately apparent: for new data it is only revealed in interoperability with
other components, and for existing data it should not have any visible effect
if set correctly. Therefore we decided it would be best to be very strict in
checks, because otherwise a typo in the table property value could only be
discovered after some data has already been written with irreversible errors.
This was the reasoning behind this part of specs.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
