Github user tejasapatil commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143312237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class CodegenContext {
// be extremely expensive in certain cases, such as deeply-nested
expressions which operate over
// inputs with wide schemas. For more details on the performance
issues that motivated this
// flat, see SPARK-15680.
- if (SparkEnv.get != null &&
SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments", false)) {
--- End diff --
There are places in codebase which do `SQLConf.get` (esp.
`CodeGenerator.scala` which is being modified in this PR). Are you suggesting
to change that everywhere like #18568 ? I think it will be good thing to do.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
