Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19449#discussion_r143318406
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -929,7 +929,7 @@ class CodegenContext {
// be extremely expensive in certain cases, such as deeply-nested
expressions which operate over
// inputs with wide schemas. For more details on the performance
issues that motivated this
// flat, see SPARK-15680.
- if (SparkEnv.get != null &&
SparkEnv.get.conf.getBoolean("spark.sql.codegen.comments", false)) {
--- End diff --
Thank you for your comments. Is it better to pass `SQLConf` to the
constructor of `CodegenContext`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
