Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19337#discussion_r143720272
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
    @@ -573,7 +584,8 @@ private[clustering] object OnlineLDAOptimizer {
           expElogbeta: BDM[Double],
           alpha: breeze.linalg.Vector[Double],
           gammaShape: Double,
    -      k: Int): (BDV[Double], BDM[Double], List[Int]) = {
    +      k: Int,
    +      epsilon: Double = 1e-3): (BDV[Double], BDM[Double], List[Int]) = {
    --- End diff --
    
    shouldn't epsilon be set in LDAModel as well to reflect the value which was 
used while training the model?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to