Github user mpjlu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19337#discussion_r143723408
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
    @@ -573,7 +584,8 @@ private[clustering] object OnlineLDAOptimizer {
           expElogbeta: BDM[Double],
           alpha: breeze.linalg.Vector[Double],
           gammaShape: Double,
    -      k: Int): (BDV[Double], BDM[Double], List[Int]) = {
    +      k: Int,
    +      epsilon: Double = 1e-3): (BDV[Double], BDM[Double], List[Int]) = {
    --- End diff --
    
    Maybe not need to set, we can add epsilon as a parameter in the model to 
save it. Because most of training parameters are not in the model, so we don't 
add epsilon to the model here. Thanks. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to