Github user sathiyapk commented on the issue:

    https://github.com/apache/spark/pull/19451
  
    @gengliangwang thanks for your review. I pushed a new commit, please let me 
know if it addresses your comments. And regarding
    
    > Also please use semanticEquals instead of sameResult
    
    I couldn't call `semanticEquals ` directly on a LogicalPlan, can you please 
give an example how to use it efficiently?
    
    > I think CombineFilters(plan) can finish in one pass.
    
    CombineFilters(plan) combines two neighbouring filters into one, so 
assuming there can be any number of filters, we would need a recursive call, so 
more than one pass. Correct me if i'm wrong, thanks.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to